Panda & Tiger level completed#21
Open
ardder wants to merge 5 commits intoRubyoffRails:masterfrom
ardder:master
Open
Panda & Tiger level completed#21ardder wants to merge 5 commits intoRubyoffRails:masterfrom ardder:master
ardder wants to merge 5 commits intoRubyoffRails:masterfrom
ardder:master
Conversation
watchman.rb
Outdated
Member
There was a problem hiding this comment.
I'd probably recommend to either stick with puts or STDOUT.
Member
|
Great job! Only stylistic points to mention. yay! I keep thinking about this line: puts "1: Monday, 2: Tuesday, 3: Wednesday, 4: Thursday, 5: Friday, 6: Saturday, 7: Sunday or Q: Quit"It's not bad --- but it does repeat some information. Like the WEEK_DAY above as a constant. I might do something like: COMMANDS = {"Q" => "Quit"}
all_choices = WEEK_DAY.merge(COMMANDS)
puts all_choices.map{ |k,v| "#{k}: #{v}"}.join(" or ")Then later, you could do something like day = select_day
if all_choices[day].nil?
puts "invalid choice #{day}, please try again"
next
endUnsure if that really makes it better not, but wanted to show an alternate flow. |
Author
|
I think you are right. I especially like BTW, I also finished the assignment of Episode 2. Can you check my code? Thanks, @jwo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.